Implement Phase 5: Product Owner Dashboard (User Story 3)

Add complete dashboard functionality for product owners and administrators to view, filter, search, and manage feedback submissions following Test-First Discipline.

Tests (T093-T105):
- Add 12 contract tests for dashboard routes (authentication, listing, filtering, search, detail view, status updates, attachment downloads, access control)
- Add 2 integration tests for complete dashboard workflow and access control enforcement
- All tests written first and verified to fail before implementation

Services (T111-T118):
- Enhance FeedbackStorageService with load_feedback_list() for pagination, filtering, searching, and sorting
- Add load_feedback_detail() to load complete feedback with attachments and analysis
- Add update_feedback_status_by_id() for status management
- Add get_attachment_path() with path traversal prevention

Routes (T119-T134):
- Implement GET /dashboard with filters, search, and pagination (50 items/page)
- Implement GET /feedback/<id> detail view with role-based access control
- Implement POST /feedback/<id>/status for status updates
- Implement GET /feedback/<id>/attachment/<filename> for secure file downloads
- Add access control helpers (administrators see all products, owners see only assigned)

Templates (T135-T136):
- Create dashboard/list.html with filter form, search, and pagination
- Create dashboard/detail.html with status update form and attachment links
- Create error_403.html for access denied
- Create error_404.html for not found

Integration & Bug Fixes:
- Update auth routes to remove /auth prefix and redirect to dashboard after login
- Update Feedback.VALID_STATUSES to include dashboard statuses (in_progress, resolved, closed)
- Register error handlers for 403 and 404 in app factory
- Fix test fixtures to use correct users.yaml format and User.hash_password()

Test Results: 39 passed, 1 skipped (all Phase 5 tests passing)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
2025-10-16 20:11:16 +02:00
co-authored by Claude
parent 0b15d8e3bc
commit adbfd23c26
11 changed files with 1403 additions and 13 deletions
+3 -8
View File
@@ -4,7 +4,7 @@ from flask_login import login_user, logout_user, login_required
from app.models.user import User
bp = Blueprint('auth', __name__, url_prefix='/auth')
bp = Blueprint('auth', __name__)
@bp.route('/login', methods=['GET', 'POST'])
@@ -28,13 +28,8 @@ def login():
login_user(user)
flash(f'Welcome back, {user.username}!', 'success')
# TODO: Redirect based on role when dashboards are implemented
# For now, redirect to index page
# if user.role == 'administrator':
# return redirect(url_for('admin.dashboard'))
# elif user.role == 'product_owner':
# return redirect(url_for('dashboard.list'))
return redirect(url_for('index'))
# Redirect to dashboard for product owners and administrators
return redirect(url_for('dashboard.list'))
else:
flash('Invalid username or password', 'error')