Replace honest-reviewer with code-review skill
- Remove honest-reviewer (Socratic/devil's-advocate approach) - Add code-review skill: high-precision review based on current best practices (confidence scoring >= 80, validate-before-report, context gathering beyond the diff, strict output contract, GLM/open-weight guardrails) - dev-workflow: point review step at code-review, findings instead of questions; also adopt issue-based plan storage with explicit user approval gate
This commit is contained in:
@@ -22,19 +22,19 @@ Discuss the task, idea, or bug with the coding agent. The outcome is an **implem
|
||||
- Summary of research and discussion
|
||||
- Implementation plan broken into discrete steps
|
||||
|
||||
Save the plan in the feature branch as `{feature-slug}-plan.md`. The file is deleted when the workflow completes.
|
||||
Create a GitLab/Git issue for the plan. The issue title starts with the feature slug, and the description contains the full plan. **WAIT for explicit user approval before creating the issue.**
|
||||
|
||||
### 2. Implementation
|
||||
|
||||
Before starting, the agent reads `AGENT.md` (project guidelines). Implementation proceeds step-by-step according to the plan. Each step is committed individually.
|
||||
**Only proceed if the user explicitly approves the plan** (e.g., `go`, `approved`, `start`). Do not start implementing on your own. Before starting, the agent reads `AGENT.md` (project guidelines). Implementation proceeds step-by-step according to the plan. Each step is committed individually.
|
||||
|
||||
### 3. Review
|
||||
|
||||
After implementation is complete, a subagent with **fresh context** reviews the code and implementation using `honest-reviewer`.
|
||||
After implementation is complete, a subagent with **fresh context** reviews the code and implementation using `code-review`.
|
||||
|
||||
### 4. Iteration
|
||||
|
||||
The agent answers the reviewer's questions and fixes any issues. This cycle continues until the reviewer subagent approves.
|
||||
The agent fixes any findings the reviewer reported. This cycle continues until the reviewer subagent approves.
|
||||
|
||||
### 5. Merge Request
|
||||
|
||||
|
||||
Reference in New Issue
Block a user