Issue: The landing page template supported displaying product descriptions,
but the Product model didn't load the description field from config.yaml files.
Changes:
- Added optional 'description' parameter to Product.__init__()
- Updated Product.to_dict() to include description (if present)
- Updated Product.from_dict() to load description from config
- Added test to verify descriptions are displayed on landing page
All 9 landing page tests passing.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Fixed the remaining url_for('index') calls that were causing test failures:
- app/routes/auth.py: Updated logout redirect to use landing.index
- app/templates/auth/login.html: Updated "Return to home" link to use landing.index
- app/templates/base.html: Removed administrator placeholder text (cleaned up)
All url_for('index') references have been replaced with url_for('landing.index').
Test results: 57 passed, 1 skipped, 4 errors (pre-existing fixture issues in performance tests)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Issues fixed:
- Fixed base.html to use url_for('landing.index') instead of url_for('index')
- Fixed error_403.html and error_404.html to use correct landing page endpoint
- Added Dashboard link in base.html nav for product owners
- Removed obsolete templates/index.html (replaced by landing page)
- Added dashboard link in landing/index.html for authenticated product owners
- Added test to verify landing page renders correctly with proper url_for references
All 8 landing page tests passing.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Adds landing page at root URL (/) that displays all active products with links to feedback submission forms. This replaces the requirement for users to know direct product URLs.
Changes:
- Added Product.load_active() method to filter and sort active products alphabetically
- Created landing route blueprint with error handling and structured logging
- Registered landing blueprint in app factory, replacing old index route
- Created landing page template with product list and empty state
- Added comprehensive contract tests (6 tests) covering active products, filtering, sorting, XSS prevention
- Added integration test for complete user flow from landing page to submission form
All 7 tests pass. User Story 1 (P1 - MVP) complete.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Feature: Enable visitors to discover and select products for feedback submission
## What was specified:
User Stories (prioritized and independently testable):
- P1: Browse and Select Product - Core discoverability functionality
- P2: See Product Availability Status - Transparency about active/archived
- P3: Direct Navigation Compatibility - Backwards compatibility preserved
Functional Requirements (14 total):
- Landing page at root URL (/) showing active products
- File-based product retrieval and filtering (status=active)
- Product name display with clickable navigation
- Graceful handling of missing descriptions
- Alphabetical sorting and empty state handling
- Server-side rendering (no JavaScript)
- XSS prevention via HTML escaping
- Access logging for monitoring
Success Criteria (8 measurable outcomes):
- ≤2 clicks to reach submission form
- <1s load time for 100 products
- Zero broken direct URLs (backwards compatibility)
- XSS prevention validated
- Works without JavaScript
Edge Cases Covered:
- No active products scenario
- All products archived
- Missing descriptions
- Long/special character product names
- Invalid submission_url_slug
## Artifacts created:
- specs/002-at-the-moment/spec.md - Full feature specification
- specs/002-at-the-moment/checklists/requirements.md - Implementation checklist
## Next steps:
- Run /speckit.plan to generate implementation plan
- Create tasks.md from plan template
- Implement feature following TDD discipline
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
All 18 Phase 7 polish tasks have been implemented and committed
(commit 5675784). This update aligns the tasks.md documentation with
the actual implementation status.
Implementation completed:
- T193-T194: Comprehensive error logging and structured JSON logging
- T195: Complete deployment guide (docs/deployment.md)
- T196-T199: Security hardening (HSTS, CSRF, cookies, XSS)
- T200-T201: Performance tests for concurrency and dashboard load
- T202-T207: Code quality, validation, and verification
- T208-T209: Health check endpoint and environment validation
- T210: Development dependencies (requirements-dev.txt)
Resolves constitution Principle V compliance (Documentation as Code).
Project status: All in-scope phases complete (1-5, 7). Phase 6 deferred.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Updated specifications to reflect that User Story 4 (Product/Service
Registration and Management) is out of scope for the proof-of-concept.
Admin UI for product/user management is deferred in favor of manual
YAML file editing.
Specification Updates:
spec.md:
- Marked User Story 4 as [DEFERRED FOR POC]
- Added rationale: Manual management sufficient for POC
- Added manual management approach documentation
- Preserved original requirements (strikethrough) for future reference
- Updated FR-045 to FR-054 to indicate DEFERRED or IMPLEMENTED status
- Clarified which features work via YAML vs need admin UI
plan.md:
- Added POC Scope Update note in Summary section
- Documented that User Stories 1-3 are IMPLEMENTED
- Explained User Story 4 deferral and manual management approach
- Preserved original plan structure for future reference
tasks.md:
- Marked Phase 6 header as [DEFERRED FOR POC]
- Added comprehensive rationale and manual management guide
- Documented what's already implemented (models, access control)
- Listed manual operations: create product, edit product, create user, etc.
- Clarified that underlying features work, only admin UI is deferred
- Preserved all T140-T192 tasks for future implementation
- Added "Future Consideration" note
Rationale:
For a proof-of-concept, the admin UI adds no validation value. The core
functionality (anonymous submission, AI analysis, dashboard access) is
fully implemented and testable. Products and users can be managed via
YAML files:
- Products: data/products/{id}/config.yaml
- Users: data/users.yaml (with bcrypt passwords)
What Works Without Admin UI:
✅ Multi-product support (Product model + access control)
✅ Product owner assignment (via users.yaml product_ids field)
✅ Unique submission URLs per product (submission_url_slug)
✅ Archived product blocking (checked in submission route)
✅ Role-based access (owners see assigned, admins see all)
Decision Benefits:
- Reduces POC scope to essential features
- Eliminates ~53 admin UI tasks (T140-T192)
- Maintains all core product/user functionality
- Enables faster POC validation
- Can be implemented later if scaling is needed
Next Steps:
Focus on Phase 7 (Polish) - production hardening, documentation,
performance verification, and deployment readiness.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Verification revealed Phase 4 was 96% complete (27/28 tasks). Implemented
missing retry logic (T081) and marked all tasks as complete in tasks.md.
Implementation Status:
- Tests (T065-T070): ✅ 6/6 complete
- 5 unit tests for AIAnalyzer interface and extraction methods
- 2 integration tests for full analysis flow
- All tests passing
- Core Implementation (T071-T092): ✅ 22/22 complete
- AIAnalyzer abstract base class with interface
- AnalysisResult dataclass for structured results
- ClaudeAnalyzer with Anthropic SDK integration
- Single-call prompt design (categorize + summarize + translate)
- Language detection and category extraction
- Summary and translation extraction with regex
- 45s API timeout handling
- NEW: Retry logic with exponential backoff (3 retries, 1s/2s/4s)
- Retries transient errors (rate limits, server errors)
- Does not retry timeouts or non-retryable errors
- Analysis storage to analysis.md
- Background threading for async analysis
- Automatic trigger on feedback submission
- Status transitions: new → analyzing → analyzed/analysis_failed
- Language and category stored in metadata.yaml
- ANTHROPIC_API_KEY documented in .env.example
- FR-016 compliance: Original content.txt preserved
- FR-021 compliance: Images stored but not OCR'd
New Implementation:
- Added retry logic for transient API failures (T081):
- Max 3 retries with exponential backoff (1s, 2s, 4s)
- Only retries rate limits and server errors
- Does not retry timeouts or permanent errors
- File: app/services/ai_analyzer.py lines 70-123
Test Results:
- 8 tests passed (unit + integration + contract)
- All analysis features verified working
- Manual analysis trigger tested
- Background analysis tested
- Error handling and status transitions verified
Integration Points:
- Automatic analysis on submission (app/routes/submission.py:93-94)
- Manual analysis trigger (app/routes/dashboard.py:207-285)
- Analysis storage (app/services/feedback_storage.py:476-548)
- Status management throughout analysis lifecycle
🎯 CHECKPOINT: User Stories 1 AND 2 work together seamlessly - feedback
is submitted AND automatically analyzed with categorization, summarization,
and translation. Manual re-analysis also available via dashboard.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Phase 3 verification revealed that all 35 tasks (T030-T064) for User Story 1
(Anonymous Feedback Submission) are fully implemented and tested. Updated
tasks.md to reflect completion status.
Implementation Status:
- Tests (T030-T039): ✅ 10/10 complete
- 9 contract tests passing (1 intentionally skipped)
- 2 integration tests passing
- Models (T040-T041): ✅ 2/2 complete
- Product model with YAML loading
- Feedback model with validation
- Storage Service (T042-T046): ✅ 5/5 complete
- FeedbackStorageService with all methods
- File Validation (T047): ✅ 1/1 complete
- ClamAV integration with graceful degradation
- Routes & Templates (T048-T062): ✅ 15/15 complete
- Submission blueprint with GET/POST routes
- Form, success, and error templates
- Validation, virus scanning, rate limiting
- Error handling for archived/non-existent products
- Test Data & Compliance (T063-T064): ✅ 2/2 complete
- Test product configuration
- FR-055 compliance (no IP logging)
Test Results:
- 10 tests passed, 1 skipped (by design)
- All validation, security, and error handling verified
- End-to-end submission flow working correctly
🎯 MVP CHECKPOINT: User Story 1 is independently functional and fully tested.
Anonymous users can submit feedback with text and/or attachments without
authentication. All security requirements (file validation, virus scanning,
rate limiting) are operational.
This marks the completion of the MVP scope as defined in the project
constitution - basic feedback submission is production-ready.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Address architectural inconsistency where environment variables were used
directly instead of through Flask's configuration system.
Issues Fixed:
1. .env file was never loaded - load_dotenv() was missing
2. Routes used os.getenv() directly instead of app.config
3. ANTHROPIC_API_KEY was defined in config but not used properly
Changes:
- config/development.py: Added load_dotenv() at module level
- app/routes/submission.py: Changed os.getenv() to current_app.config.get()
- app/routes/dashboard.py: Changed os.getenv() to current_app.config.get()
Benefits:
- Proper separation of concerns (config vs code)
- .env files now work as expected in development
- Easier to test (can mock app.config)
- Consistent with Flask best practices
- Production env vars still work (no dotenv in production config)
Configuration Flow:
Development: .env → load_dotenv() → os.environ → DevelopmentConfig → app.config
Production: System env vars → os.environ → ProductionConfig → app.config
Application: app.config.get('ANTHROPIC_API_KEY')
All 49 tests passing (1 skipped)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Fix 'Client.__init__() got an unexpected keyword argument proxies' error
that occurred when manually triggering AI analysis from the dashboard.
Issue:
- Anthropic SDK v0.8.0 had compatibility issues with httpx client
- Error occurred when instantiating anthropic.Anthropic(api_key=key)
- Prevented manual analysis trigger from working in production
Solution:
- Upgraded anthropic package from 0.8.0 to 0.71.0
- Updated requirements.txt with new version
- All tests still passing (49 passed, 1 skipped)
The newer SDK version resolves the internal httpx proxy parameter issue
and provides better compatibility with the current Python environment.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Implement dashboard functionality to manually trigger AI analysis for
feedback that was submitted before Phase 4 or failed analysis. Adds
detection mechanism to identify which feedback has been analyzed.
Features:
- Manual analysis trigger route: POST /feedback/{id}/analyze
- Detection of whether feedback has been analyzed (analysis.md exists)
- Dashboard UI button showing "Analyze" or "Re-analyze"
- Visual feedback for feedback without text content
- Comprehensive error handling and flash messages
Implementation:
- app/routes/dashboard.py: Added trigger_analysis() route handler
- app/routes/dashboard.py: Updated detail() to pass analysis status
- app/services/feedback_storage.py: Added has_analysis() helper method
- app/templates/dashboard/detail.html: Added analyze button UI
- tests/contract/test_dashboard_routes.py: Added 3 new contract tests
Testing:
- test_post_trigger_analysis_success: Successful manual analysis
- test_post_trigger_analysis_no_content: Reject empty content
- test_post_trigger_analysis_unauthenticated: Auth required
- All 49 tests passing (1 skipped)
User Experience:
- Green box with "Analyze" button for unanalyzed feedback
- Blue box with "Re-analyze" button for already analyzed feedback
- Red box with info message for feedback without text content
- Flash messages show success/error after analysis
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Implement automatic AI analysis of feedback submissions using Claude API,
including language detection, categorization, summarization, and translation
to product owner's preferred language.
Tasks Completed (T065-T092):
- T065-T069: Unit tests for AI analyzer (5 tests)
- T070: Integration test for full AI analysis workflow
- T071: Created AIAnalyzer abstract base class interface
- T072: Added AnalysisResult dataclass to feedback model
- T073: Implemented ClaudeAnalyzer with Anthropic SDK
- T074: Integrated Claude API with 45s timeout
- T075: Designed single-call analysis prompt
- T076: Language detection implementation
- T077: Category extraction with validation
- T078: Summary generation (1-2 sentences)
- T079: Translation extraction
- T080: Timeout handling for Claude API
- T081: API error handling with proper exceptions
- T082: Analysis storage to analysis.md file
- T083: Formatted markdown output for analysis
- T084: Background analysis trigger on submission
- T085: Non-blocking async analysis via threading
- T086: Status update to 'analyzing' before analysis
- T087: Status update to 'analyzed' on success
- T088: Status update to 'analysis_failed' on error
- T089: Metadata update with category and language
- T090: Environment configuration for ANTHROPIC_API_KEY
- T091: Verification that original content.txt preserved (FR-016)
- T092: Verification that images not analyzed via OCR (FR-021)
Features:
- Abstract AIAnalyzer interface for multiple AI providers
- ClaudeAnalyzer implementation using Anthropic API
- Background threading for non-blocking analysis
- Flask app context management in background threads
- Comprehensive error handling and status tracking
- Original content preservation (FR-016 compliance)
- Image storage without OCR (FR-021 compliance)
Testing:
- 5 unit tests for AI analyzer components
- 2 integration tests for full analysis workflow
- All 46 tests passing (1 skipped)
- Mock-based testing to avoid API calls
Files Changed:
- app/models/feedback.py: Added AnalysisResult dataclass
- app/routes/submission.py: Background analysis integration
- app/services/ai_analyzer.py: NEW - AI analysis service
- app/services/feedback_storage.py: Analysis storage methods
- tests/unit/test_ai_analyzer.py: NEW - Unit tests (5 tests)
- tests/integration/test_ai_analysis_flow.py: NEW - Integration tests (2 tests)
- tests/integration/test_feedback_submission_flow.py: Threading mock added
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Add complete dashboard functionality for product owners and administrators to view, filter, search, and manage feedback submissions following Test-First Discipline.
Tests (T093-T105):
- Add 12 contract tests for dashboard routes (authentication, listing, filtering, search, detail view, status updates, attachment downloads, access control)
- Add 2 integration tests for complete dashboard workflow and access control enforcement
- All tests written first and verified to fail before implementation
Services (T111-T118):
- Enhance FeedbackStorageService with load_feedback_list() for pagination, filtering, searching, and sorting
- Add load_feedback_detail() to load complete feedback with attachments and analysis
- Add update_feedback_status_by_id() for status management
- Add get_attachment_path() with path traversal prevention
Routes (T119-T134):
- Implement GET /dashboard with filters, search, and pagination (50 items/page)
- Implement GET /feedback/<id> detail view with role-based access control
- Implement POST /feedback/<id>/status for status updates
- Implement GET /feedback/<id>/attachment/<filename> for secure file downloads
- Add access control helpers (administrators see all products, owners see only assigned)
Templates (T135-T136):
- Create dashboard/list.html with filter form, search, and pagination
- Create dashboard/detail.html with status update form and attachment links
- Create error_403.html for access denied
- Create error_404.html for not found
Integration & Bug Fixes:
- Update auth routes to remove /auth prefix and redirect to dashboard after login
- Update Feedback.VALID_STATUSES to include dashboard statuses (in_progress, resolved, closed)
- Register error handlers for 403 and 404 in app factory
- Fix test fixtures to use correct users.yaml format and User.hash_password()
Test Results: 39 passed, 1 skipped (all Phase 5 tests passing)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Improvements:
1. Added 15 comprehensive User model unit tests
2. Created TECHNICAL_DEBT.md to track test gaps and known issues
3. Updated constitution with Bug Fix Protocol (v1.1.0)
User Model Tests (tests/unit/test_user_model.py):
- Test user creation and properties
- Test is_active property (Flask-Login integration)
- Test password hashing and verification
- Test serialization (to_dict/from_dict)
- Test CRUD operations (create, load, update, delete)
- Test error conditions (duplicate username, invalid role)
Technical Debt Documentation (docs/TECHNICAL_DEBT.md):
- Missing authentication route tests
- CSRF testing disabled by design
- Dashboard routes not implemented (planned)
- ClamAV integration not fully tested
- All 3 MVP bugs documented with lessons learned
Constitution Amendment (v1.0.0 → v1.1.0):
- Added Bug Fix Protocol requiring:
- Write failing test before fix
- Document in TECHNICAL_DEBT.md
- Commit test and fix together
- Lessons learned capture
Test Coverage Improvement:
- Before: 10 tests (8 contract + 2 integration)
- After: 26 tests (8 contract + 2 integration + 15 unit + 1 skipped)
- User model: 0% → 100% coverage
Rationale: Bugs found during manual testing revealed insufficient
test coverage. This addresses the gap and establishes process to
prevent future coverage deficiencies.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
After successful login, the app tried to redirect to admin.dashboard
or dashboard.list routes that don't exist yet (Phase 5 & 6).
Changes:
- Login now redirects to index page for all users
- Logout redirects to index page instead of submission.form
- Base template navigation shows "Coming in Phase X" messages
instead of broken links to unimplemented routes
- Added TODO comments for future dashboard implementation
This allows login/logout to work properly in MVP (Phase 3) while
dashboard features are pending implementation.
Bug: werkzeug.routing.exceptions.BuildError: Could not build url
for endpoint 'admin.dashboard'
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Create init_admin.py script to properly initialize the admin user
with correct password hash for "admin123".
Usage:
python init_admin.py
This script:
- Creates admin user if it doesn't exist
- Uses proper bcrypt password hashing
- Stores user data in data/users.yaml (gitignored)
- Provides clear feedback about user creation
Credentials created:
- Username: admin
- Password: admin123
- Role: administrator
Note: data/users.yaml is gitignored (correct for user data), so
admin user must be initialized on each installation.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Flask-Login's UserMixin provides is_active as a read-only property.
Attempting to set it as an instance attribute caused a conflict.
Solution:
- Store active status in private attribute _is_active
- Override is_active property to return custom value
- Update to_dict() to use _is_active
This allows proper Flask-Login integration while maintaining
custom active status tracking.
Bug found during login testing: AttributeError when calling
User.get_by_username() which triggered from_dict() → __init__().
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Add CSRF token hidden input fields to:
- Submission form (submission/form.html)
- Login form (auth/login.html)
Also fix broken link in login page that referenced submission.form
without required product_slug parameter. Changed to link to index page.
Bug found during manual testing when submitting feedback resulted in
"Bad Request - The CSRF token is missing" error.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Changed terminology from "API" to "Routes" to better reflect server-rendered HTML approach:
- Renamed submission_api.md → submission_routes.md
- Renamed dashboard_api.md → dashboard_routes.md
- Renamed admin_api.md → admin_routes.md
- Updated headers to clarify "Response Type: Server-rendered HTML (no JavaScript required)"
- Updated references in plan.md and quickstart.md
This clarifies that the application uses traditional web routes with form submissions
and HTML responses, not REST API endpoints with JSON.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Complete Phase 0 (Research) and Phase 1 (Design) of implementation planning workflow:
- plan.md: Technical context, constitution check, and project structure
- research.md: Technology decisions for AI integration, file storage, authentication, security
- data-model.md: Domain entities with validation rules and state transitions
- contracts/: API specifications for submission, dashboard, and admin endpoints
- quickstart.md: Developer setup guide with test-first workflow
- CLAUDE.md: Updated agent context with tech stack
All constitutional requirements validated. Ready for task generation phase.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
gurixandClaude