- Remove honest-reviewer (Socratic/devil's-advocate approach) - Add code-review skill: high-precision review based on current best practices (confidence scoring >= 80, validate-before-report, context gathering beyond the diff, strict output contract, GLM/open-weight guardrails) - dev-workflow: point review step at code-review, findings instead of questions; also adopt issue-based plan storage with explicit user approval gate
47 lines
1.5 KiB
Markdown
47 lines
1.5 KiB
Markdown
---
|
|
name: dev-workflow
|
|
description: Personal development workflow for software projects.
|
|
---
|
|
|
|
# Dev Workflow
|
|
|
|
This skill enforces my personal development workflow for software projects.
|
|
|
|
## Branch Strategy
|
|
|
|
- **Main branch**: `master` or `main` (production)
|
|
- **Development**: Always on feature branches off main
|
|
- **New work**: Features, fixes, and chores each get their own branch
|
|
|
|
## Workflow
|
|
|
|
### 1. Research / Discussion / Plan
|
|
|
|
Discuss the task, idea, or bug with the coding agent. The outcome is an **implementation plan** that includes:
|
|
|
|
- Summary of research and discussion
|
|
- Implementation plan broken into discrete steps
|
|
|
|
Create a GitLab/Git issue for the plan. The issue title starts with the feature slug, and the description contains the full plan. **WAIT for explicit user approval before creating the issue.**
|
|
|
|
### 2. Implementation
|
|
|
|
**Only proceed if the user explicitly approves the plan** (e.g., `go`, `approved`, `start`). Do not start implementing on your own. Before starting, the agent reads `AGENT.md` (project guidelines). Implementation proceeds step-by-step according to the plan. Each step is committed individually.
|
|
|
|
### 3. Review
|
|
|
|
After implementation is complete, a subagent with **fresh context** reviews the code and implementation using `code-review`.
|
|
|
|
### 4. Iteration
|
|
|
|
The agent fixes any findings the reviewer reported. This cycle continues until the reviewer subagent approves.
|
|
|
|
### 5. Merge Request
|
|
|
|
Create an MR/PR and inform the user.
|
|
|
|
## Language Rule
|
|
|
|
- **Plans and artifacts**: Always in **English**
|
|
- **User discussions**: Any language
|