refactor: keep style-specific config off the base class via **kwargs
The base AlarmStyle contract carried music_file, forcing SimpleStyle to accept a parameter it never uses. Move style-specific config to the subclass: the base __init__ takes only set_led (**kwargs swallows the rest); each style declares the keyword args it actually uses (BlinkStyle: music_file; SimpleStyle: none). The runner passes config as keyword args and each style keeps only what it needs, so the base contract never grows as styles are added — a future 'talk' style adds talk_file to its own signature, not to the base. README plugin contract updated.
This commit is contained in:
+3
-2
@@ -23,8 +23,9 @@ class BlinkStyle(AlarmStyle):
|
||||
exactly that many times. A wrong count starts a fresh sequence.
|
||||
"""
|
||||
|
||||
def __init__(self, set_led, music_file=None):
|
||||
super().__init__(set_led, music_file)
|
||||
def __init__(self, set_led, music_file=None, **kwargs):
|
||||
super().__init__(set_led, **kwargs)
|
||||
self.music_file = music_file
|
||||
self.state = STATE_RINGING
|
||||
self.target_blinks = 0
|
||||
self.user_presses = 0
|
||||
|
||||
Reference in New Issue
Block a user